Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider handle is misplaced inside of the slider bar on IE11 #8620

Closed
kjellr opened this issue Aug 6, 2018 · 5 comments
Closed

Slider handle is misplaced inside of the slider bar on IE11 #8620

kjellr opened this issue Aug 6, 2018 · 5 comments
Labels
Browser Issues Issues or PRs that are related to browser specific problems CSS Styling Related to editor and front end styles, CSS-specific issues. Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended

Comments

@kjellr
Copy link
Contributor

kjellr commented Aug 6, 2018

Describe the bug

On IE11, the handle (dot) of the slider component we use in our Settings Sidebar appears clipped inside of the slider bar:

screen shot 2018-08-06 at 2 48 52 pm

The slider also appears to be only 1px tall. As a result, the slider is difficult to use in this case.

To Reproduce

  1. Use IE11
  2. Add one of the following blocks: paragraph, cover image, column, latest comments, latest posts, gallery.
  3. Look in the block settings panel for the slider.
  4. See error

Appearance in Safari for reference

screen shot 2018-08-06 at 2 54 27 pm

screen shot 2018-08-06 at 2 49 17 pm

Appearance in IE11

screen shot 2018-08-06 at 2 54 09 pm

screen shot 2018-08-06 at 2 48 52 pm

Tested in
Windows 7, IE 11.0.9600.19080
Gutenberg 3.4

@kjellr kjellr added [Type] Bug An existing feature does not function as intended Browser Issues Issues or PRs that are related to browser specific problems labels Aug 6, 2018
@aduth
Copy link
Member

aduth commented May 31, 2019

Confirmed this is still an issue as of 2019-05-31.

Suggestions to explore for possible resolution:

@aduth aduth added Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts labels May 31, 2019
@jasmussen
Copy link
Contributor

I'm unaware of why the slider may have regressed — I've a good VM set up, so I'm pretty confident that it must've worked when I shipped that PR. So I would also suggest that the 1px height is likely the issue.

@tellthemachines
Copy link
Contributor

Lack of visibility of the slider is no longer an issue in IE, but the handle now appears incorrectly positioned:

slider

This can be easily fixed by removing the padding-top: 15px; from the parent Wrapper. Removing it has no effect on the other browsers.

@tellthemachines tellthemachines added the CSS Styling Related to editor and front end styles, CSS-specific issues. label Apr 21, 2020
@tellthemachines tellthemachines changed the title Slider handle is clipped inside of the slider bar on IE11 Slider handle is misplaced inside of the slider bar on IE11 Apr 21, 2020
@paaljoachim
Copy link
Contributor

Is this issue still valid? What is the next step?

@youknowriad
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems CSS Styling Related to editor and front end styles, CSS-specific issues. Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

6 participants