Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync up alignment options for the Archives and Categories blocks #9413

Closed
kjellr opened this issue Aug 28, 2018 · 5 comments · Fixed by #9469
Closed

Sync up alignment options for the Archives and Categories blocks #9413

kjellr opened this issue Aug 28, 2018 · 5 comments · Fixed by #9469
Labels
[Block] Archives Affects the Archives Block [Block] Categories Affects the Categories Block [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@kjellr
Copy link
Contributor

kjellr commented Aug 28, 2018

Update:

Since opening this issue, the state here has been flipped around. Here's the current state of things:

  • The Categories block has left/center/right/wide/full alignments
  • The Archives block has left/center/right alignments

Clarifying my thoughts on this: Text or list-based blocks like these shouldn't ship with wide/full alignments. They don't clearly benefit from the additional space: in fact, they become less readable with longer line length. Archives + Categories should have only left/center/wide alignment options.


Original Ticket:

Describe the bug

The Archives block currently contains options for Left, Center, and Right alignment:

screen shot 2018-08-28 at 3 38 09 pm

The Categories block currently contains those same options, but also includes "Full" alignment:

screen shot 2018-08-28 at 2 45 14 pm

Since these blocks are similar in function and appearance, we should sync up these alignment options. To do so, I suggest we remove the "Full" alignment from the Categories block — it doesn't seem like it'd be a frequently used setting for a list.

@kjellr kjellr added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks labels Aug 28, 2018
@kjellr kjellr mentioned this issue Aug 28, 2018
3 tasks
@ZebulanStanphill
Copy link
Member

Notably, the Latest Comments and Latest Posts blocks both have wide/full alignment options. I would prefer if wide/full alignments were added to more blocks, rather than removed from existing ones. I think the wide/full alignment options are more useful than the left/right float alignment options for the widget blocks.

@caxco93
Copy link
Contributor

caxco93 commented Aug 29, 2018

I'm using Gutenberg Version 3.6.2 . What is the reason for me not being able to see the "Full" alignment option for the Categories Block?

@ZebulanStanphill
Copy link
Member

@caxco93 The Wide and Full alignment options are only shown if your theme declares support for them.

https://wordpress.org/gutenberg/handbook/extensibility/theme-support/#wide-alignment

@caxco93
Copy link
Contributor

caxco93 commented Aug 29, 2018

@ZebulanStanphill thank you zebulan 👍

@nfmohit
Copy link
Member

nfmohit commented Aug 30, 2018

Submitted PR #9469 addressing this enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Archives Affects the Archives Block [Block] Categories Affects the Categories Block [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
5 participants