Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert link: add named anchor links to the link suggestions when searching for links #9660

Open
maximebj opened this issue Sep 6, 2018 · 7 comments
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Enhancement A suggestion for improvement.

Comments

@maximebj
Copy link
Contributor

maximebj commented Sep 6, 2018

Hi!

The anchor tool is pretty neat. I love the way the anchor name auto slugifies itself when typing.

But when it come to make the link to the anchor, we assume than people knows than they have to write # + the name of the anchor

It would be nice to add a suggestion in the URL component, something like this:

anchor

And adding back the post type of the suggestions (I'm dealing with many Post types and found this feature very useful in the previous editor)

It may be more difficult to do it from page to another, but a first simple step would be to make it available to the current page yet.

Or did I missed something ?

@ianbelanger79 ianbelanger79 added the [Type] Enhancement A suggestion for improvement. label Sep 6, 2018
@designsimply designsimply added Needs Design Feedback Needs general design feedback. [Feature] UI Components Impacts or related to the UI component system labels Sep 7, 2018
@designsimply designsimply changed the title Go further with anchors / links Insert link: add named anchor links to the link suggestions when searching for links Sep 7, 2018
@designsimply
Copy link
Member

I am adding the Needs Design Feedback label to this issue to get a reply about your suggestion to add in-page anchor links (jump links) to the link search. I also updated the title to try to make it a little more clear. Thanks for posting!

And adding back the post type of the suggestions (I'm dealing with many Post types and found this feature very useful in the previous editor)

This should be in a separate issue. There is already an open issue about unifying the design for the link toolbar so I've asked about that in a comment on #6392 and will wait for a reply to that separately.

@maximebj
Copy link
Contributor Author

maximebj commented Sep 7, 2018

Ok thanks !

No problem for the title rewrite, my english is not perfect yet so you did well :)

@karmatosed
Copy link
Member

I think for phase one we can ship without adding in page anchors. It is a good idea for iterating though, so let's put into ideas. Thanks!

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Oct 9, 2018
@designsimply
Copy link
Member

Re-opening this request to add same-page named anchors to the suggested link search results when adding a link for consideration in Phase 2.

@designsimply designsimply reopened this Feb 1, 2019
@designsimply designsimply added the Needs Decision Needs a decision to be actionable or relevant label Feb 1, 2019
@mtias mtias removed the Needs Decision Needs a decision to be actionable or relevant label Nov 17, 2019
@paaljoachim
Copy link
Contributor

It is a very good idea adding in page anchor links to the link modul drop down.
Here is a suggestion:

In-page-Anchor-link-suggestion

@mtias mtias added [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) and removed [Feature] UI Components Impacts or related to the UI component system labels Jul 13, 2021
@porg
Copy link

porg commented Sep 3, 2021

  1. 👍 Good UI design to have the type-labels "#" "post" page" near the results.

  2. ❗️ For huge sites there may be the need to add a layout row below the search box:
    Match in: [√] Posts [√] Pages [√] Products [√] Anchors
    But I think that won't be necessary, the next point should solve it almost entirely.

  3. 💡 More important than reducing search scope is
    a) the intelligence of the search. Should match in the combination of title + slug + anchor link + anchor-target-text (if Wordpress has that info), i.e. searching for "creativity brain" giving you /creativity-techniques#brainstorming
    b) To change the result display a bit, like:
    Awesome Creativity Techniques # Blitz Brainstorming
    /creativity-techniques#brainstorming
    b1) Propose to skip the domain.com part for internal links, as it's redundant, just visual noise.
    b2) For anchor results I propose to show page-title in bold + anchor-name in normal weight. Design rationale: Just think of having generic anchors like #introduction on multiple pages. How do you know which is which if not also seeing the title and the slug more clearly (hence b1!)

@porg
Copy link

porg commented Sep 3, 2021

As of Wordpress 5.8 this feature is not live yet.

  • Is there already a alpha version of it?
  • Can it be activated with a preference or feature-toggle?

I'm currently building a website with a lot of micro content accessible by #anchor-links and would benefit a lot from a linker dialog which matches #anchor-links too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

7 participants