Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InnerBlocks layouts - no controls show #9714

Closed
virgiliud opened this issue Sep 8, 2018 · 3 comments
Closed

InnerBlocks layouts - no controls show #9714

virgiliud opened this issue Sep 8, 2018 · 3 comments
Labels
[Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P Needs Decision Needs a decision to be actionable or relevant [Type] Question Questions about the design or development of the editor.

Comments

@virgiliud
Copy link

virgiliud commented Sep 8, 2018

I assigned layout as an object to InnerBlocks and no controls are presented to the user in the editor.

<InnerBlocks layouts={ {
	normal: { label: 'Normal Width', icon: 'align-center' },
	wide: { label: 'Width Width', icon: 'align-wide' },
} } />

I am using Gutenberg 3.7.0

@aduth
Copy link
Member

aduth commented Sep 10, 2018

Related:

It was originally a goal of InnerBlocks to support automated UI generation, i.e. present controls to the user to switch layout regions. This was never implemented, and in #7841 the documentation was updated to avoid confusion on this point. Currently it is the responsibility of the block to implement its own controls and assign to the layout attribute.

I am okay to leave this issue remain open as a two-pronged question:

  • Is the layouts concept still desirable?
  • And if so, should controls be generated automatically for each layout?

@aduth aduth added [Type] Question Questions about the design or development of the editor. Needs Decision Needs a decision to be actionable or relevant [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P labels Sep 10, 2018
@gziolo
Copy link
Member

gziolo commented May 23, 2019

I can't see layouts prop in InnerBlocks definition. It would mean this issue should be closed, @jorgefilipecosta or @aduth, can you confirm?

@aduth
Copy link
Member

aduth commented May 23, 2019

It can be closed. The layouts concept was removed in #11029.

@aduth aduth closed this as completed May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P Needs Decision Needs a decision to be actionable or relevant [Type] Question Questions about the design or development of the editor.
Projects
None yet
Development

No branches or pull requests

3 participants