Add title to gutenberg mobile #13199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
added
[Status] In Progress
This was referenced Jan 10, 2019
pinarol
reviewed
Jan 15, 2019
pinarol
reviewed
Jan 17, 2019
|
|
||
| return { | ||
| clearSelectedBlock, | ||
| }; |
There was a problem hiding this comment.
so this was the thing I was referring to by disptaching to store, just like this one we can also inject onUpdate to props and use editPost( { title } ) to update the post in the store, just like the web side here:
pinarol
approved these changes
Jan 17, 2019
There was a problem hiding this comment.
Thanks Diego for this! My tests passed all ok! 🎉
I think there's one last thing that needs to be addressed and I've added a comment about it but feel free to create an issue for it and handle that separately, at this time it is enough if we just don't forget about it.
…rnmobile/372-add-title-to-gutenberg-mobile * 'master' of https://github.com/WordPress/gutenberg: (56 commits) Save package-lock.json file changes (#13481) Plugin: Deprecate gutenberg_add_responsive_body_class (#13461) Add speak messages to the feature toggle component. (#13385) Plugin: Deprecate gutenberg_kses_allowedtags (#13460) Plugin: Deprecate gutenberg_bulk_post_updated_messages (#13472) Plugin: Avoid calling deprecated gutenberg_silence_rest_errors (#13446) Plugin: Deprecate gutenberg_remove_wpcom_markdown_support (#13473) Fix: Categories block: add custom classes only to wrapper (#13439) is-shallow-equal: Use ES5 ruleset from eslint-plugin module (#13428) Update and Organize Contributors Guide per #12916 (#13352) Dismissible-notices: fix text overlapping icon (X) (#13371) Framework: Remove 5.0-merged REST API integrations (#13408) Plugin: Remove 5.0-merged block registration functions, integrations (#13412) Framework: Bump minimum required WP to 5.x (#13370) [Mobile] Improve keyboard hide button (#13415) Improve castError handling of non strings (#13315) Fix: File block add custom class (#13432) Consider making Fullscreen Mode effects visible only on larger screens (#13425) Update plugin version to 4.9.0 (#13436) DateTimePicker: fix prop warning for (#12933) ...
|
Merging, but I'll be going through these PRs tomorrow to list any pending work. Thanks for the feedback everyone. |
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* temporarily disable link formatting * Make sure RichText resigns focus when unmounted (#13048) * Implements a native version of post-title. * Removes some unnecessary log calls. * Submits a few lint fixes. * Fixes a linting issue. * When focusing the title, any focused block loses its focus. * FocusOut is now wired for post-title for mobile. * Removes unused some code. * Added a file I failed to commit. * Fixes a linting issue.
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* temporarily disable link formatting * Make sure RichText resigns focus when unmounted (#13048) * Implements a native version of post-title. * Removes some unnecessary log calls. * Submits a few lint fixes. * Fixes a linting issue. * When focusing the title, any focused block loses its focus. * FocusOut is now wired for post-title for mobile. * Removes unused some code. * Added a file I failed to commit. * Fixes a linting issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
post-titlecomponent support for mobile.How has this been tested?
This PR should be tested through either of these branches:
gutenberg-mobile: wordpress-mobile/gutenberg-mobile#450
WPiOS: wordpress-mobile/WordPress-iOS#10794
Types of changes
Adds a
.native.jsfile with the mobile-specific implementation ofpost-title.To do:
Fix the build, which is failing for some reason. This shouldn't hold the reviews back, though.
Checklist: