Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Remove SCSS entry from CODEOWNERS #15216

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Conversation

aduth
Copy link
Member

@aduth aduth commented Apr 26, 2019

Previously: #14062 (comment)

This pull request seeks to remove the *.scss entry from the CODEOWNERS file.

The behavior of CODEOWNERS is such that the last match will take precedence:

# Order is important; the last matching pattern takes the most
# precedence. When someone opens a pull request that only
# modifies JS files, only @js-owner and not the global
# owner(s) will be requested for a review.
*.js    @js-owner

https://help.github.com/en/articles/about-code-owners#codeowners-syntax

The proposed benefit of removing this entry is:

  • Avoid overburdening a small set of individuals
  • Ensure to notify those who are otherwise marked as code owners for the given file placement

Testing Instructions:

This is a repository metadata file. There is no impact on the application.

@aduth aduth added the Framework Issues related to broader framework topics, especially as it relates to javascript label Apr 26, 2019
@aduth aduth requested a review from chrisvanpatten April 26, 2019 15:06
@chrisvanpatten
Copy link
Contributor

Go forth and merge!

@aduth aduth merged commit b4c05ae into master Apr 29, 2019
@aduth aduth deleted the remove/codeowners-scss branch April 29, 2019 12:18
@youknowriad youknowriad added this to the 5.6 (Gutenberg) milestone May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants