reverts the rename of postsToShow as it may cause breaking changes #15453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
requested review from
ajitbohra,
gziolo,
jorgefilipecosta,
noisysocks,
notnownikki,
Soean,
talldan and
youknowriad
as code owners
gziolo
reviewed
May 6, 2019
| @@ -135,7 +135,7 @@ function register_block_core_latest_posts() { | |||
| 'categories' => array( | |||
| 'type' => 'string', | |||
| ), | |||
| 'postCount' => array( | |||
| 'postsToShow' => array( | |||
There was a problem hiding this comment.
phpcs will complain, spaces need to align with other fields
gziolo
approved these changes
May 6, 2019
There was a problem hiding this comment.
@draganescu, thanks for working on it. This is ready to merge once Travis is happy.
gziolo
added
[Block] Latest Posts
This was referenced May 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#14627 renamed postsToShow to postCount on my suggestion in the latest posts block. This reverts that as I didn't consider that is a breaking change. It could be renamed still but the effor to write the deprecation code is not justified.
How has this been tested?
Local testing of the latest posts code
Checklist: