Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: Added temporary workaround for the default config used with lint-js command #17744

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Scripts: Added temporary workaround for the default config used with lint-js command #17744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/scripts/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## Master

### Bug Fixes

- Added a temporary workaround for the default config used with `lint-js` command. It uses linting rules for both e2e and unit tests with all files until override files globbing logic is fixed when using `eslint` with `--config` (related [issue](https://github.com/eslint/eslint/issues/11558)).

## 5.0.0 (2019-09-16)

### Breaking Changes
Expand Down
10 changes: 9 additions & 1 deletion packages/scripts/config/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
module.exports = {
root: true,
extends: [ 'plugin:@wordpress/eslint-plugin/recommended' ],
extends: [
'plugin:@wordpress/eslint-plugin/recommended',

// Temporary workaround to use linting rules for both e2e and unit tests with all files
// until override files globbing logic is fixed when using with --config.
// @see https://github.com/eslint/eslint/issues/11558
'plugin:@wordpress/eslint-plugin/test-e2e',
'plugin:@wordpress/eslint-plugin/test-unit',
],
};