Playground: Only build design system once. #17818
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epiqueras
added
Framework
5 tasks
ntwb
approved these changes
Oct 9, 2019
|
Already done in #17762. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the design system was being built twice, due to the relevant script being called explicitly in Travis right after another script, the playground build, that included it.
This also caused problems with how the playground is built on Travis, because it uses the argument appending functionality of npm scripts to pass the public URL that should be used. This meant that the parameter was being received by the last script, the design system build, instead of the playground build as intended.
How has this been tested?
It was verified that the playground can be built and served.
Checklist: