-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Navigator: Use default block appender #22590
Merged
draganescu
merged 2 commits into
master
from
update/use-default-block-appender-in-navigator
Jun 3, 2020
Merged
Block Navigator: Use default block appender #22590
draganescu
merged 2 commits into
master
from
update/use-default-block-appender-in-navigator
Jun 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the Block Navigator to use the default block appender instead of the button block appender.
noisysocks
added
[Feature] Inserter
The main way to insert blocks using the + button in the editing interface
Needs Design Feedback
Needs general design feedback.
[Feature] List View
Menu item in the top toolbar to select blocks from a list of links.
[Feature] Navigation Screen
labels
May 25, 2020
Size Change: -15.3 kB (1%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
talldan
reviewed
May 25, 2020
3 tasks
draganescu
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM 🚀
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Inserter
The main way to insert blocks using the + button in the editing interface
[Feature] List View
Menu item in the top toolbar to select blocks from a list of links.
Needs Design Feedback
Needs general design feedback.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22170.
Changes the Block Navigator to use the default block appender instead of the button block appender.
To test: