-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Title Block: Add alignment and tag level support #22843
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeatling
added
[Type] Enhancement
A suggestion for improvement.
[Block] Site Title
Affects the Site Title Block
labels
Jun 2, 2020
apeatling
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
June 2, 2020 22:15
12 tasks
Size Change: +6.75 kB (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
Converting to WIP/draft to add font size and color support before review. |
@apeatling I think we can add the alignments first and do the others separately, just to keep things leaner for review |
6 tasks
epiqueras
requested changes
Jun 4, 2020
epiqueras
approved these changes
Jun 4, 2020
12 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #21087
Description
Adds text alignment support to the Site Title block. This also adds support for changing the heading level or using a paragraph as the tagName, but does not expose this in the UI.
How has this been tested?
Screenshots
Types of changes
New feature.
Checklist: