Fix useBlockSync race condition #23292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Package] Block editor
|
Size Change: -11 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
epiqueras
requested changes
Jun 18, 2020
| @@ -108,6 +108,9 @@ export default function useBlockSync( { | |||
| // waiting for React renders for changes. | |||
| const onInputRef = useRef( onInput ); | |||
| const onChangeRef = useRef( onChange ); | |||
| onInputRef.current = onInput; | |||
There was a problem hiding this comment.
This is a side effect, so it needs to be wrapped in an effect hook.
There was a problem hiding this comment.
I wrapped in an effect but I suspect that it's what's causing the issue. Subscriptions might be called with an outdated listener before the effect runs, maybe I should use useLayoutEffect. I'll need to confirm again in asblocks.
There was a problem hiding this comment.
Yes, useLayoutEffect is used for stuff like this that needs to be sync.
There was a problem hiding this comment.
So I tested again, and useEffect seems sufficient so i think we can move forward here.
noahtallen
reviewed
Jun 18, 2020
youknowriad
force-pushed
the
fix/race-condition-use-block-sync
branch
from
baafa5b to
4dfdee4
Compare
epiqueras
approved these changes
Jun 20, 2020
This was referenced Jun 24, 2020
Closed
6 tasks
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while working on https://github.com/youknowriad/asblocks.
Sometimes when you change something in blocks, like type a character, the
onChangehandler gets called twice for the same value, causing all sorts of issues if a new change happened in the meantime. I think it's related to the fact that the subscription is "renewed" each time onChange or onInput changes. This shouldn't be the case and subscriptions should just use the last callbacks. That's what this PR does (that solved the issue for me btw)