-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image editing: try transparent zoom control #23646
Conversation
Size Change: -218 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
I do appreciate how this makes the zoom control work better in constrained spaces, something which would also be solved by moving it to the actual toolbar. But I wonder if there's sufficient contrast here, and I personally really liked the aspect ratio moving out of the toolbar and into context of the zoom bar. Have we looked into how hard it would be to get the zoom toolbar into the block toolbar itself? I do sense that it's getting very close to sunday here ... but on the other hand, we might end up with an image editing interface that feels frankensteinian :( |
Yes, what Diego suggested, that it's behaving like a popover inside the toolbar. |
And we also move the input field inside the toolbar? |
Yep, and that's why it's important that all other buttons are hidden in this cropping/editing mode. |
Closing in favour of #23677. |
Description
Follow up to #23418.
For now it's not possible to put the range control inside the toolbar because it already handles horizontal keyboard navigation. In #23418 an additional toolbar was created, but I find it quite tightly packed for smaller images and it obscures the image.
Another reason why I like this more is that the image, the scrolling and pinching gesture for zooming are closely connected to the slider control.
How has this been tested?
Screenshots
Types of changes
Checklist: