-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve rootClientId comparison in useBlockDropZone #24307
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Feature] Drag and Drop
Drag and drop functionality when working with blocks
labels
Jul 31, 2020
6 tasks
Size Change: -9 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
I think I've also come across instances where rootClientId was null... We should be fixing this in general everywhere to be consistent (pick between undefined or empty string). |
ellatrix
approved these changes
Jul 31, 2020
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Drag and Drop
Drag and drop functionality when working with blocks
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addreses #23020 (comment)
There's a slight discrepancy between values for
rootClientId
that represent top-level blocks.getBlockRootClientId
returns an empty string for a top level block.BlockList
components tend to useundefined
because the prop forrootClientId
is omitted for the top level block list.useBlockDropZone
performs a comparison between rootClientIds that originate from these two separate places.This PR smooths over the inconsistency in that hook by defaulting
targetRootClientId
(which is sourced fromBlockList
) to an empty string.How has this been tested?
Dragging and dropping top-level blocks should continue to work. Specifically dragging a block downwards should result in the block being inserted in the correct place.
Types of changes
Non-breaking code quality improvement
Checklist: