Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try block toolbar inline edit slot #25177

Closed
wants to merge 7 commits into from

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Sep 9, 2020

Description

Reverts #23613 and replaces it with a 'popover' style slot as advised by the a11y team in #24021 (comment).

How does this work?

This PR introduces a new slot on the toolbar BlockToolbarInlineEditSlot. When this slot contains a fill, it signals to a context provider that other toolbar content should be 'visually hidden' and only the fill should be rendered.

Additionally, anything rendered in the fill is wrapped in a PopoverWrapper (the same as the one introduced in #24429) which provides popover behaviors but is rendered inline.

How has this been tested?

This PR doesn't actually implement anything visible, but I've rebased #24021 on top of this, and that's the PR should be tested.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@talldan talldan added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. [Feature] Navigation Screen labels Sep 9, 2020
@talldan talldan self-assigned this Sep 9, 2020
@github-actions
Copy link

github-actions bot commented Sep 9, 2020

Size Change: -5.29 kB (0%)

Total Size: 1.2 MB

Filename Size Change
build/a11y/index.js 1.14 kB +1 B
build/block-directory/index.js 8.41 kB +1 B
build/block-editor/index.js 123 kB -5.25 kB (4%)
build/block-editor/style-rtl.css 11 kB -37 B (0%)
build/block-editor/style.css 11 kB -36 B (0%)
build/block-library/index.js 135 kB -14 B (0%)
build/block-serialization-default-parser/index.js 1.78 kB +2 B (0%)
build/blocks/index.js 47.5 kB -3 B (0%)
build/components/index.js 202 kB -29 B (0%)
build/compose/index.js 9.42 kB -3 B (0%)
build/core-data/index.js 12 kB +20 B (0%)
build/data/index.js 8.44 kB +12 B (0%)
build/dom/index.js 4.42 kB -2 B (0%)
build/edit-navigation/index.js 10.4 kB -4 B (0%)
build/edit-post/index.js 306 kB +55 B (0%)
build/edit-site/index.js 19.6 kB -6 B (0%)
build/edit-widgets/index.js 17.6 kB +1 B
build/editor/index.js 45.3 kB +3 B (0%)
build/element/index.js 4.45 kB +1 B
build/format-library/index.js 7.48 kB -8 B (0%)
build/i18n/index.js 3.55 kB +1 B
build/keyboard-shortcuts/index.js 2.39 kB -1 B
build/list-reusable-blocks/index.js 3.02 kB +3 B (0%)
build/media-utils/index.js 5.12 kB +1 B
build/notices/index.js 1.69 kB -2 B (0%)
build/plugins/index.js 2.44 kB +1 B
build/primitives/index.js 1.34 kB -1 B
build/redux-routine/index.js 2.85 kB +1 B
build/rich-text/index.js 13.7 kB +3 B (0%)
build/server-side-render/index.js 2.61 kB +1 B
build/token-list/index.js 1.24 kB -2 B (0%)
build/url/index.js 4.06 kB +1 B
build/viewport/index.js 1.74 kB -2 B (0%)
build/warning/index.js 1.14 kB +7 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/annotations/index.js 3.52 kB 0 B
build/api-fetch/index.js 3.34 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-library/editor-rtl.css 8.59 kB 0 B
build/block-library/editor.css 8.59 kB 0 B
build/block-library/style-rtl.css 7.6 kB 0 B
build/block-library/style.css 7.59 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/data-controls/index.js 1.27 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/style-rtl.css 6.24 kB 0 B
build/edit-post/style.css 6.22 kB 0 B
build/edit-site/style-rtl.css 3.3 kB 0 B
build/edit-site/style.css 3.3 kB 0 B
build/edit-widgets/style-rtl.css 2.79 kB 0 B
build/edit-widgets/style.css 2.79 kB 0 B
build/editor/editor-styles-rtl.css 492 B 0 B
build/editor/editor-styles.css 493 B 0 B
build/editor/style-rtl.css 3.8 kB 0 B
build/editor/style.css 3.8 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 622 B 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/priority-queue/index.js 789 B 0 B
build/shortcode/index.js 1.7 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@afercia
Copy link
Contributor

afercia commented Sep 11, 2020

I'm not able to build this branch, getting a huge dump of errors apparently related to TypeScript and SVGs, see example below. Any idea what's going wrong?

packages/icons/src/library/trending-up.js:8:4 - error TS2741: Property 'path' is missing in type '{ d: string; }' but required in type 'Pick<SVGProps<SVGPathElement>, "string" | "end" | "local" | "color" | "clip" | "style" | "fill" | "stroke" | "x" | "y" | "alphabetic" | "hanging" | "ideographic" | ... 455 more ... | "zoomAndPan">'.

8  	<Path d="M3.445 16.505a.75.75 0 001.06.05l5.005-4.55 4.024 3.521 4.716-4.715V14h1.5V8.25H14v1.5h3.19l-3.724 3.723L9.49 9.995l-5.995 5.45a.75.75 0 00-.05 1.06z" />
   	 ~~~~


Found 372 errors.

@talldan talldan force-pushed the try/block-toolbar-inline-edit-slot branch from 3da4ed1 to ed254f8 Compare September 22, 2020 04:08
@talldan
Copy link
Contributor Author

talldan commented Nov 27, 2020

Superseded by #25890

@talldan talldan closed this Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants