Include block CSS in the plugin ZIP #27884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Package] Project management automation
youknowriad
approved these changes
Dec 24, 2020
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
|
Thank you for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported in core-editor slack that no blocks had CSS applied when an FSE was active using the latest 9.6 release from the repository. Using
masterorrelease/9.6everything worked fine.It looks like #25220 introduced code-splitting for CSS, so core only enqueues the block's CSS when the block is used. We adapted our building processes to accommodate the new way block assets are generated. This PR adapts the plugin ZIP creation to include the block's CSS as well.
Test
release/9.6branch../bin/build-plugin-zip.sh.