Page List & Navigation Screen: Fix flyout bg color in page list. #29932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Block] Navigation
|
Size Change: -50 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Mar 18, 2021
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Background color inheritance wasn't fully working in the Page List block. This PR fixes that.
Specifically, if a navigation block has a background color defined, that background color should also be used to colorize flyout submenus.
But if it doesn't, then we have to define both a background color, and a text color, in order to be sure flyout menus are legible.
Before:
After:
How has this been tested?
Please use a non-FSE theme, because there's an issue with the navigation screen where style files aren't applied in that context.
Please test the navigation screen, and the navigation block. You need to have both a number of pages and subpages published. The in the navigation block, please use both the Page List block, and a custom menu item with a number of submenus defined.
Try with and without a background color for the navigation block. Please verify submenu item colors are correctly applied.
Fixes #29101.
Checklist: