Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert React Portals for most uses #3083

Merged
merged 1 commit into from
Oct 20, 2017
Merged

Revert React Portals for most uses #3083

merged 1 commit into from
Oct 20, 2017

Conversation

ellatrix
Copy link
Member

See #3082.
This reverts commit 1fbb24f.

@codecov
Copy link

codecov bot commented Oct 20, 2017

Codecov Report

Merging #3083 into master will increase coverage by 1.42%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3083      +/-   ##
==========================================
+ Coverage   32.32%   33.75%   +1.42%     
==========================================
  Files         216      217       +1     
  Lines        6134     6609     +475     
  Branches     1079     1191     +112     
==========================================
+ Hits         1983     2231     +248     
- Misses       3502     3682     +180     
- Partials      649      696      +47
Impacted Files Coverage Δ
blocks/editable/index.js 10.5% <ø> (ø) ⬆️
blocks/inspector-controls/index.js 88.88% <ø> (ø) ⬆️
blocks/block-controls/index.js 0% <ø> (ø) ⬆️
editor/sidebar/block-inspector/index.js 0% <0%> (ø) ⬆️
editor/provider/index.js 0% <0%> (ø) ⬆️
editor/block-toolbar/index.js 0% <0%> (ø) ⬆️
editor/block-settings-menu/content.js 11.53% <0%> (-15.74%) ⬇️
blocks/library/html/index.js 19.04% <0%> (-4.03%) ⬇️
blocks/library/latest-posts/index.js 7.22% <0%> (-2.78%) ⬇️
editor/modes/visual-editor/inserter.js 91.66% <0%> (-1.67%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e187494...8963cc8. Read the comment docs.

@ellatrix ellatrix requested review from aduth and youknowriad October 20, 2017 11:44
@ellatrix ellatrix changed the title Revert React Portals for uses Revert React Portals for most uses Oct 20, 2017
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not catching the issues on the first review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants