Add menu-item-home class to Navigation for front page #37301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice, thank you! I see the class on the frontend: I don't see it in the editor, should we have it there too?:
|
jasmussen
added
[Block] Navigation
|
@jasmussen can you try it again? I'm getting the class on the front-end but some async updates were a bit wonky so I'd appreciate another set of eyes. |
|
Took the latest for a spin, and I might be doing something wrong. I'm still seeing the class on the frontend, but not in the editor. Or was that not the change? Thanks for the work! |
|
@jasmussen it was, of course, a tpyo. |
georgeh
force-pushed
the
add/navigation-menu-item-home
branch
from
ee2dd25 to
6d0f12c
Compare
|
Size Change: +60 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Dec 21, 2021
There was a problem hiding this comment.
Nice! This works well for me. See it on the frontend:
And in the editor:
I'd love a code sanity check, perhaps by @tellthemachines since she's touched this. And this would not be urgent and can easily wait until after the break.
Also, one final question: menu-item-home as a class name is probably the right one to use since it matches the existing legacy classname. Just want to flag again whether this is the name we want to use, or whether there's another "this is the homepage" class used somewhere in the codebase.
|
Cherry-picked for the 5.9.1. |
Mamaduka
pushed a commit
that referenced
this pull request
Feb 16, 2022
* Add menu-item-home class to Navigation for the front page Closes #29423
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29423
Description
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).