-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wp-env]: Add support to override core
by the WP_ENV_CORE
environment variable.
#40407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
torounit
changed the title
Add support to override
[wp-env]: Add support to override Apr 18, 2022
core
by the WP_ENV_CORE
environment variable.core
by the WP_ENV_CORE
environment variable.
noahtallen
approved these changes
Apr 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well for me!
@noahtallen Thank you for testing! |
This was referenced Aug 17, 2022
bph
added
the
Needs Dev Note
Requires a developer note for a major WordPress release cycle
label
Aug 29, 2022
Added label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs Dev Note
Requires a developer note for a major WordPress release cycle
[Tool] Env
/packages/env
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
allow override
core
by theWP_ENV_CORE
environment variable as likeWP_ENV_PHP_VERSION
.Why?
Just as we test multiple versions of PHP, we should be able to test multiple versions of WordPress. This makes it easier to test plugins on CI.
Testing Instructions
$ WP_ENV_CORE=WordPress/WordPress#5.9.1 npm run wp-env start --update