Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberControl: Add TypeScript prop types #43791

Merged
merged 21 commits into from
Sep 8, 2022
Merged

NumberControl: Add TypeScript prop types #43791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
0f5a389
NumberControl: Improve types
mirka Sep 1, 2022
8f6edb1
Add description to InputControl classname
mirka Sep 1, 2022
786c1af
RangeControl: Add ts-expect-errors
mirka Sep 1, 2022
cb4fdb0
ColorPicker: Add ts-expect-errors
mirka Sep 1, 2022
4473bd5
UnitControl: Get types from NumberControl
mirka Sep 1, 2022
b9c1fe3
UnitControl: Remove redundant aria-label
mirka Sep 1, 2022
418e2db
NumberControl: Simplify controls in story
mirka Sep 1, 2022
d77a143
Simplify `stepOverride` type
mirka Sep 6, 2022
b2f34f1
Add string number utils
mirka Sep 6, 2022
c30c715
Replace `parseFloat` with `ensureNumber`
mirka Sep 6, 2022
ddcc53a
Simplify `numberControlStateReducer` type
mirka Sep 6, 2022
aadc586
Cast keyboard event
mirka Sep 6, 2022
4212c0d
Disable `value` control in story
mirka Sep 6, 2022
f759d35
UnitControl: Remove `children` from types
mirka Sep 6, 2022
fd7f905
Make the `step` prop visible in Docs view
mirka Sep 6, 2022
6000e4b
UnitControl: Remove irrelevant props
mirka Sep 6, 2022
fc7bcca
UnitControl: Fixup controls
mirka Sep 6, 2022
9cf3203
Use InputControlProps where possible
mirka Sep 7, 2022
90948f0
Improve TODO comments
mirka Sep 7, 2022
4cda1ea
Add changelog
mirka Sep 7, 2022
ba48ff7
Fix e2e test
mirka Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

- Remove unused `normalizeArrowKey` utility function ([#43640](https://github.com/WordPress/gutenberg/pull/43640/)).
- `ToggleGroupControl`: Rename `__experimentalIsIconGroup` prop to `__experimentalIsBorderless` ([#43771](https://github.com/WordPress/gutenberg/pull/43771/)).
- `NumberControl`: Add TypeScript types ([#43791](https://github.com/WordPress/gutenberg/pull/43791/)).
- Refactor `FocalPointPicker` to function component ([#39168](https://github.com/WordPress/gutenberg/pull/39168)).
- `Guide`: use `code` instead of `keyCode` for keyboard events ([#43604](https://github.com/WordPress/gutenberg/pull/43604/)).
- `ToggleControl`: Convert to TypeScript and streamline CSS ([#43717](https://github.com/WordPress/gutenberg/pull/43717)).
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/color-picker/input-with-slider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export const InputWithSlider = ( {
label={ label }
hideLabelFromVision
value={ value }
// @ts-expect-error TODO: Resolve discrepancy in NumberControl
onChange={ onChange }
prefix={
<Spacer
Expand Down
3 changes: 3 additions & 0 deletions packages/components/src/input-control/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,9 @@ export interface InputBaseProps extends BaseProps, FlexProps {
* @default false
*/
disabled?: boolean;
/**
* The class name to be added to the wrapper element.
*/
className?: string;
id?: string;
/**
Expand Down
192 changes: 0 additions & 192 deletions packages/components/src/number-control/index.js
View file
Open in desktop

This file was deleted.

Loading