BlockDraggable: Change prop name passed to children when dragging is disabled #44371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: -1 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR tries to make props passed to
BlockDraggablechildren more consistent. I think the current prop was leftover from the #27669 reactor.This also fixes the
React does not recognize the 'isDragable' prop on a DOM elementerror that's visible in certain scenarios.P.S. Noticed this while debugging #44341.
Why?
To avoid React error when block draggable props are passed directly into children.
Example - https://github.com/WordPress/gutenberg/blob/trunk/packages/block-editor/src/components/block-mover/index.js#L67-L80
Testing Instructions
packages/e2e-tests/plugins/cpt-locking.php.React does not recognize the 'isDraggable' prop on a DOM elementisn't displayed in the console.