Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'should_skip_block_supports_serialization' with the core utility method #47195

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

Mamaduka
Copy link
Member

What?

PR replace gutenberg_should_skip_block_supports_serialization with wp_should_skip_block_supports_serialization.

Why?

The plugin now requires a minimum WP 6.0, so we can remove the gutenberg_should_skip_block_supports_serialization compat layer.

Testing Instructions

  1. Downgrade WP installation to WP 6.0 - wp core update --version=6.0.3 --force
  2. Confirm there are no fatal errors when visiting the testing site - frontend and the editor.

@Mamaduka Mamaduka self-assigned this Jan 16, 2023
@Mamaduka Mamaduka added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Code Quality Issues or PRs that relate to code quality labels Jan 16, 2023
@github-actions
Copy link

Flaky tests detected in b3ee252.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3931615590
📝 Reported issues:

@Mamaduka Mamaduka requested a review from ntsekouras January 17, 2023 06:28
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Mamaduka Mamaduka merged commit 7824a63 into trunk Jan 17, 2023
@Mamaduka Mamaduka deleted the remove/skip-block-serialization-util branch January 17, 2023 09:04
@github-actions github-actions bot added this to the Gutenberg 15.1 milestone Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants