-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Site Editor]: Add delete
action for pages in navigation sidebar
#51101
Merged
ntsekouras
merged 3 commits into
trunk
from
add/delete-page-site-editor-navigation-sidebar
May 31, 2023
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
71 changes: 71 additions & 0 deletions
71
packages/edit-site/src/components/page-actions/delete-page-menu-item.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { useDispatch, useSelect } from '@wordpress/data'; | ||
import { decodeEntities } from '@wordpress/html-entities'; | ||
import { useState } from '@wordpress/element'; | ||
import { store as coreStore } from '@wordpress/core-data'; | ||
import { __, sprintf } from '@wordpress/i18n'; | ||
import { | ||
MenuItem, | ||
__experimentalConfirmDialog as ConfirmDialog, | ||
} from '@wordpress/components'; | ||
import { store as noticesStore } from '@wordpress/notices'; | ||
|
||
export default function DeletePageMenuItem( { postId, onRemove } ) { | ||
const [ isModalOpen, setIsModalOpen ] = useState( false ); | ||
const { createSuccessNotice, createErrorNotice } = | ||
useDispatch( noticesStore ); | ||
const { deleteEntityRecord } = useDispatch( coreStore ); | ||
const page = useSelect( | ||
( select ) => | ||
select( coreStore ).getEntityRecord( 'postType', 'page', postId ), | ||
[ postId ] | ||
); | ||
async function removePage() { | ||
try { | ||
await deleteEntityRecord( | ||
'postType', | ||
'page', | ||
postId, | ||
{}, | ||
{ throwOnError: true } | ||
); | ||
createSuccessNotice( | ||
sprintf( | ||
/* translators: The page's title. */ | ||
__( '"%s" deleted.' ), | ||
decodeEntities( page.title.rendered ) | ||
), | ||
{ | ||
type: 'snackbar', | ||
id: 'edit-site-page-removed', | ||
} | ||
); | ||
onRemove?.(); | ||
} catch ( error ) { | ||
const errorMessage = | ||
error.message && error.code !== 'unknown_error' | ||
? error.message | ||
: __( 'An error occurred while deleting the page.' ); | ||
|
||
createErrorNotice( errorMessage, { type: 'snackbar' } ); | ||
} finally { | ||
setIsModalOpen( false ); | ||
} | ||
} | ||
return ( | ||
<> | ||
<MenuItem onClick={ () => setIsModalOpen( true ) } isDestructive> | ||
{ __( 'Delete' ) } | ||
</MenuItem> | ||
<ConfirmDialog | ||
isOpen={ isModalOpen } | ||
onConfirm={ removePage } | ||
onCancel={ () => setIsModalOpen( false ) } | ||
> | ||
{ __( 'Are you sure you want to delete this page?' ) } | ||
</ConfirmDialog> | ||
</> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { __ } from '@wordpress/i18n'; | ||
import { DropdownMenu, MenuGroup } from '@wordpress/components'; | ||
import { moreVertical } from '@wordpress/icons'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import DeletePageMenuItem from './delete-page-menu-item'; | ||
|
||
export default function PageActions( { | ||
postId, | ||
className, | ||
toggleProps, | ||
onRemove, | ||
} ) { | ||
return ( | ||
<DropdownMenu | ||
icon={ moreVertical } | ||
label={ __( 'Actions' ) } | ||
className={ className } | ||
toggleProps={ toggleProps } | ||
> | ||
{ () => ( | ||
<MenuGroup> | ||
<DeletePageMenuItem | ||
postId={ postId } | ||
onRemove={ onRemove } | ||
/> | ||
</MenuGroup> | ||
) } | ||
</DropdownMenu> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could probably add an
undo
action here.. Maybe in a follow up? 😄