List View: Unify shortcut handlers #61130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
Size Change: +249 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Apr 26, 2024
Comment on lines
+268
to
+269
| setOpenedBlockSettingsMenu( undefined ); | ||
| updateFocusAndSelection( newlySelectedBlocks[ 0 ], false ); |
There was a problem hiding this comment.
It is odd that we have to use setOpenedBlockSettingsMenu to ensure the dropdown is closed after the action. One would think that moving focus to the List View item would handle that.
P.S. The issue isn't consistently reproducible manually but failed in e2e tests.
Mamaduka
commented
Apr 26, 2024
|
|
||
| // If multiple blocks are selected, deselect all blocks when the user | ||
| // presses the escape key. | ||
| if ( event.keyCode === ESCAPE && selectedClientIds.length > 0 ) { |
There was a problem hiding this comment.
This needs to be converted to a core/block-editor/unselect event, and there's no need to trigger an event when only one block is selected.
I'll create a follow-up PR for this.
There was a problem hiding this comment.
Here's the follow-up #61223. I left the block count check after realizing that List View allows deselecting a single block.
kevin940726
approved these changes
Apr 30, 2024
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR removes special List View shortcut handling (introduced in #50422) from the
BlockSettingsDropdowncomponent. Now, all the list view shortcuts are handled in a single place.Why?
It matches how the block shortcuts are handled in the canvas.
How?
PR moves the shortcut handlers from the
ListViewBlockSelectButtonto theListViewBlockcomponent. This way, events propagated from the popover are also captured.It's better to review with whitespace hidden - https://github.com/WordPress/gutenberg/pull/61130/files?diff=unified&w=1
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2024-04-26.at.12.51.00.mp4