Pages: Trash view should default to table layout. #63138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +21 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Could you explain why? I thought it's quite nice that you can preview the trashed posts. |
|
This one was a hangover from #59659, originally added by Saxon. You're still able to preview trashed posts by switching layout. But generally speaking when you visit the Trash it's because you want to restore a specific item(s), or empty trash. In neither case do you really need the preview, and the Table layout is better optimised for bulk actions. I'd welcome more design feedback, but this is working well for me. |
jameskoster
added
the
[Feature] DataViews
This comment was marked as off-topic.
This comment was marked as off-topic.
|
cc: @WordPress/gutenberg-design as this one is pending additional design feedback. |
jameskoster
approved these changes
Jul 12, 2024
jorgefilipecosta
deleted the
update/Pages-Trash-view-should-default-to-table-layout
branch
|
It looks like performance tests started failing on trunk after this PR got merged. You can find example trace here: https://github.com/WordPress/gutenberg/actions/runs/9905030088. |
|
Thank you for the heads up @Mamaduka, everything was passing when this PR was merged probably some conflict with another change. I'm trying to fix the issue. |
jorgefilipecosta
added a commit
that referenced
this pull request
Jul 12, 2024
This reverts commit 905b41d.
This was referenced Jul 12, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: ellatrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #63128.
Makes the page trash view default to the table view.
cc: @jameskoster
Testing Instructions
I opened the pages list at wp-admin/site-editor.php?postType=page.
I switched to the trash view, and I verified the default view type of that view was table, while for the other the default list was kept.