DataViews: Optimize the templates dataviews by extracting the fields definition #63929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Performance
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
changed the title
|
Size Change: +322 B (+0.02%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
I'm not seeing any regressions. |
ellatrix
reviewed
Jul 25, 2024
| getValue: ( { item } ) => item.author_text, | ||
| render: ( { item } ) => { | ||
| return <AuthorField item={ item } />; | ||
| }, |
There was a problem hiding this comment.
Can't this be just render: AuthorField?
ellatrix
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55083
What?
When working on #63923 I noticed that the dataviews fields all "remount" when the fields "render" function instance change. This was not visible for us before but it can happen very often as you filter, switch views...
What it means is that "fields" definition should ideally be a top level module variable rather than something defined within components and that creates a new instance very often. It also forces us to think about fields more consistently across layouts...
This PR optimizes the templates dataviews by moving the fields definition outside the component and into their own file.
I'm not entirely sure that we'll see an impact on our numbers right away but I'm sure this will benefit users and the feeling of performance as you interact with the data views.
Testing Instructions
The current PR focuses on the templates dataviews, so just ensure there's no regressions there. Especially UI/design regressions for the different fields.