-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Title: Add Border Support #64581
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Flaky tests detected in 7526d3c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10423152747
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well 👍
✅ Global styles apply correctly
✅ Block instance styles override global styles
✅ Styles apply consistently between editor and frontend
✅ Box sizing allows parent to enforce width
✅ Default display of border controls matches spacing controls
Screen.Recording.2024-08-19.at.3.46.03.PM.mp4
Thank you both for reviewing this PR. |
Co-authored-by: shail-mehta <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
What?
Add Border support in the
Query Title
block.Part of #43247
Why?
Query Title
block is missing border support.How?
Add the border support in block.json.
Testing Instructions
Query Title
block's border is Configurable via Global Styles.Query Title
Block and Apply the border Styles.Query Title
block styles take precedence over global Styles.Query Title
block borders is showing correctly in both the Editor and Frontend.Screenshots or Screencast
add-border-support-in-query-title.mp4