Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Title: Add Border Support #64581

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

shail-mehta
Copy link
Member

What?

Add Border support in the Query Title block.

Part of #43247

Why?

Query Title block is missing border support.

How?

Add the border support in block.json.

Testing Instructions

  • Go to Global Styles Settings. ( Under Appearance > Editor > Styles > Edit styles > Blocks )
  • Make sure that Query Title block's border is Configurable via Global Styles.
  • Edit Archive Template & Add Query Title Block and Apply the border Styles.
  • Verify that Query Title block styles take precedence over global Styles.
  • Verify that Query Title block borders is showing correctly in both the Editor and Frontend.

Screenshots or Screencast

add-border-support-in-query-title.mp4

@shail-mehta shail-mehta added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Query Title Affects the Query Title Block labels Aug 16, 2024
@shail-mehta shail-mehta self-assigned this Aug 16, 2024
@shail-mehta shail-mehta requested a review from ajitbohra as a code owner August 16, 2024 16:32
@shail-mehta shail-mehta marked this pull request as draft August 16, 2024 16:32
Copy link

github-actions bot commented Aug 16, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <[email protected]>
Co-authored-by: ramonjd <[email protected]>
Co-authored-by: aaronrobertshaw <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta shail-mehta marked this pull request as ready for review August 16, 2024 16:50
Copy link

Flaky tests detected in 7526d3c.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10423152747
📝 Reported issues:

Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the following:

✅ Global styles
✅ Theme.json
✅ Block level

Screenshot 2024-08-19 at 9 54 55 AM

Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well 👍

✅ Global styles apply correctly
✅ Block instance styles override global styles
✅ Styles apply consistently between editor and frontend
✅ Box sizing allows parent to enforce width
✅ Default display of border controls matches spacing controls

Screen.Recording.2024-08-19.at.3.46.03.PM.mp4

@shail-mehta
Copy link
Member Author

Thank you both for reviewing this PR.

@shail-mehta shail-mehta merged commit 31e9078 into trunk Aug 19, 2024
74 checks passed
@shail-mehta shail-mehta deleted the add/query-title-border-support branch August 19, 2024 11:51
@github-actions github-actions bot added this to the Gutenberg 19.1 milestone Aug 19, 2024
bph pushed a commit to bph/gutenberg that referenced this pull request Aug 31, 2024
Co-authored-by: shail-mehta <[email protected]>
Co-authored-by: ramonjd <[email protected]>
Co-authored-by: aaronrobertshaw <[email protected]>
@fabiankaegy fabiankaegy mentioned this pull request Oct 1, 2024
97 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Title Affects the Query Title Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants