Modal: Allow preventing close requests #67635
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Enhancement
mirka
force-pushed
the
modal-prevent-close
branch
from
253b1e2 to
ba7c3b5
Compare
mirka
force-pushed
the
modal-prevent-close
branch
from
ba7c3b5 to
3b56e94
Compare
jsnajdr
reviewed
Dec 5, 2024
There was a problem hiding this comment.
A better name for the prop could be onBeforeClose. There is prior art:
beforeinputDOM event oninputelement that allows you to change or cancel what is being typed into theinputbefore its value is changedbeforeunloadDOM event runs when navigating away from page, and allows to cancel the navigation
You could also await the call. Then the callback can return a promise. Sometime it takes time to do the validation. And await also doesn't mind if the callback is synchronous and returns a boolean directly. The function that calls the callback is already async.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Demonstrates a way for the consumer to cancel the user's close request.
Currently only implemented for close button clicks, just as a proof of concept.
Why?
How?
Testing Instructions
See the "Prevent Close Request" story for the Modal component.