Test caption length when considering to show editable #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 5, 2017
Merged
Can be undefined for new block. We may want to look to provide default, but for now simply test truthiness.
aduth
commented
May 5, 2017
| @@ -120,7 +120,7 @@ registerBlock( 'core/quote', { | |||
| onMerge={ mergeWithPrevious } | |||
| showAlignments | |||
| /> | |||
| { ( citation || !! focus ) && ( | |||
| { ( ( citation && citation.length > 0 ) || !! focus ) && ( | |||
There was a problem hiding this comment.
Preempting a concern here: Yes, this is ugly. Rather than extract to a separate variable, I think we should acknowledge its ugliness and try to avoid it altogether by providing default values for children. This should be addressed separately.
|
Ok, let's merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #673
Related: #668
This pull request seeks to resolve an issue where caption and citation fields are shown when the block has no focus and no caption content. In doing so, it also removes invalid paragraphs from the demo
post-content.jstext.Implementation notes:
The
childrenmatcher always returns an array. An array is truthy even when it has no values. Instead, test length of the array to see if any content is to be shown.Testing instructions:
Verify that only images, quotes, and embeds with caption text show the caption Editable, except when focused (in which case, Editable should always be shown).