-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace wp globals with module equivalents #742
Conversation
Technically available, but treat as error in linting context to avoid temptation
f651e03
to
249ccfc
Compare
Rebased to resolve conflicts, include new additions, and also remove I discovered in the process that we may also want to change our React |
@aduth I think this is good thing, it makes things more explicit. I think you should rebase and merge this branch right after, because you'll always have conflicts :) |
Let's just change this to Edit: though I agree that should be a future PR. |
@aduth I think we should proceed with this, though arguably it would be easier to just start over. I can help if you like. Do you have concerns with the approach here? |
Yes, we should probably do this, and it's probably easier to start over (essentially a find-replace on One main concern is other |
Good question... also seems related to #941. |
Superseded by #1332 |
Previously: #716, #736, #737, #739
This pull request expands upon the restructuring outlined in #716, replacing
wp.
global calls with their "WordPress modules" equivalents. It should be the final step in this process.Testing instructions:
Ensure the build completes, tests pass, and editor initializes and appears without regressions. Specifically observe that no errors are logged to the console, blocks appear as registered with localized (likely English) labels intact.