Add Archives block #7949
Add Archives block #7949
Conversation
talldan
force-pushed
the
add/archives-block
branch
from
82008dd to
31bccd8
Compare
core-blocks/archives/block.js
Outdated
| this.toggleDisplayAsDropdown = this.toggleDisplayAsDropdown.bind( this ); | ||
| } | ||
|
|
||
| toggleShowPostCounts() { |
There was a problem hiding this comment.
Can we use just one toggle function for both attributes? See: https://github.com/WordPress/gutenberg/pull/7941/files#diff-4a7082059a72e724bea52a0a00c65773R35
There was a problem hiding this comment.
I've changed this now to a functional component in ad5aa1d as per previous feedback on the old PR, so I don't think making them a single function would be workable now. On the plus side they're both one-liners now. :)
core-blocks/archives/index.php
Outdated
| } | ||
|
|
||
| $block_content = sprintf( | ||
| '<div class="%1$s">%2$s</div>', |
There was a problem hiding this comment.
Nice catch! It should be a ul when rendered as a list, and I've kept it as a div when rendered as a dropdown - 65025c1
Co-authored-by: Pascal Birchler <[email protected]> Co-authored-by: Miina Sikk <[email protected]> Co-authored-by: Weston Ruter <[email protected]>
…tor view Use of `pointer-events` to disable interaction was problematic. It didn't disabled the dropdown version of the block and it doesn't prevent keyboard interaction. The Disabled component handles these situations.
talldan
force-pushed
the
add/archives-block
branch
from
31bccd8 to
ad5aa1d
Compare
|
Hey @noisysocks & @mcsf - I think I've addressed all the review feedback from #5495 now. Would be great if one of you could look over may changes to make sure they're ok. Thanks! |
| export const settings = { | ||
| title: __( 'Archives' ), | ||
|
|
||
| description: __( 'Display a monthly archive of your site’s Posts.' ), |
There was a problem hiding this comment.
FWIW, filter widget_archives_dropdown_args can change the periodic interval, meaning "monthly" may become inaccurate. However, I could see filtering as a more advanced feature, and sticking with "monthly" offers the benefit of conveying the basic idea of the block more clearly than e.g. "Display a periodic archive […]". Because of this, I don't mind sticking with the current copy.
mcsf
changed the title
afercia
added
the
[Feature] Widgets Screen
This PR is a continuation of #5495, moved to a local branch for easier collaboration. Props @miina for the bulk of the implementation.
Uses #5602
Continued archives block implementation from #1518 and #5495. Archive block implementation that uses similar output and filters as the archives widget. Has alignment toolbar within the block (
left,center,right).Screenshots:
Block toolbar:
Inspector toolbar:
Dropdown view:
List view:
Fixes #1464.