Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freesound preview for valid file could 404 #1321

Closed
AetherUnbound opened this issue Dec 13, 2022 · 0 comments · Fixed by WordPress/openverse-catalog#973
Closed

Freesound preview for valid file could 404 #1321

AetherUnbound opened this issue Dec 13, 2022 · 0 comments · Fixed by WordPress/openverse-catalog#973
Assignees
@stacimc
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🔧 tech: airflow Involves Apache Airflow 🐍 tech: python Involves Python

Comments

@AetherUnbound
Copy link
Collaborator

Description

It appears that the preview URLs which Freesound provides may 404 even for valid URLs. See the full context in #1578.

We'll want to handle the missing preview files gracefully. Since lacking a preview means the sound can't be played in the frontend (or even on the provider's website), we've decided that we should just skip these records entirely if the preview link 404s.

Additional context
@AetherUnbound AetherUnbound added 🐍 tech: python Involves Python 💻 aspect: code Concerns the software code in the repository 🔧 tech: airflow Involves Apache Airflow 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Dec 13, 2022
@stacimc stacimc mentioned this issue Apr 17, 2023
Closed
3 tasks
@stacimc stacimc self-assigned this Jan 25, 2023
@stacimc stacimc mentioned this issue Jan 25, 2023
Merged
8 tasks
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Apr 17, 2023
@obulat obulat transferred this issue from WordPress/openverse-catalog Apr 17, 2023
@AetherUnbound AetherUnbound mentioned this issue Apr 17, 2023
Closed
1 task
@obulat obulat moved this from 📋 Backlog to ✅ Done in Openverse Backlog Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stacimc stacimc

Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🔧 tech: airflow Involves Apache Airflow 🐍 tech: python Involves Python
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Discard audio file when preview 404s fetching filesize WordPress/openverse-catalog
2 participants
@AetherUnbound @stacimc