-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern Submission: Can not set full alignment for nested Cover block #457
Comments
As can be seen in the video, the same actually applies for wide alignment. |
I think this is a Gutenberg bug (either this one WordPress/gutenberg#37036 or this one WordPress/gutenberg#33374). Are you able to do this on a regular WP site with Gutenberg + a block-based theme? |
@ryelle You are right, the issue occurs once I swith the theme to Twenty Twenty-Two. (I'm also using Gutenberg 12.8.1 plugin in my localhost setup.) But I'm a bit confused: Checking out the code of a pattern preview on WPORG it seems you guys are using Twenty Twenty-One theme there. However, when I try to use the same setup in my localhost (with some additional styles I could get from the code inspector to match pattern preview widths and colors), I get different display of some patterns (such as #458). Also, it seems that pattern editor is using Twenty Twenty-One theme too. But you say I should try to replicate this GitHub repo issue with a block theme. I tried to visit pattern library's Twenty Twenty-One's Why there is discrepancy in editor and pattern preview (aforementioned #458) if the theme seems to be the same? Can you please provide info about how to set up my localhost "pattern draft" WordPress environment to match WPORG pattern preview and editor styles? Could this info be shared publicly? |
Yeah, the editor here, and the live preview, are set up using a "fake" block theme that uses the Twenty Twenty-One styles, but sets up a very basic block-based theme so that we can unlock all the editor functionality.
You can set up this project itself by following the readme, but you'll still need to use the same creator page locally. I would recommend using the Pattern Creator itself. |
That's unfortunate :) Could you please also take a look what's going on with inconsistent widths as described in #458? It's confusing when WPORG pattern editor and preview don't match. Even users copying such pattern don't know what to expect when pasting it to their website - IF they copy it as it looks totally terrible in WPORG pattern preview. |
Since this is confirmed to be the same gutenberg bug, I'm going to close the issue. Whenever Gutenberg fixes the problem, we'll inherit the fix. I'll reply to #458 over on that issue. |
Describe the bug
It seems like I am unable to set full alignment for nested Cover block (Cover within Cover, for example). The "full-width" option is missing for this child Cover block in editor.
Currently I need to set actual
alignfull
class manually on the nested Cover block to achieve the desired effect.To Reproduce
Steps to reproduce the behavior:
(If it helps, you can see the issue in https://wordpress.org/patterns/pattern/14072/edit/ )
Expected behavior
I should be able to set full alignment for nested Cover block too.
Screenshots
Here is a little video of the issue:
chrome_kzaVEtn3Yc.mp4
The text was updated successfully, but these errors were encountered: