Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert WebP to AVIF on upload #1724

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from
Open

Convert WebP to AVIF on upload #1724

wants to merge 7 commits into from
+34 −2

Conversation

mukeshpanchal27
Copy link
Member

Summary

Fixes #1557

Relevant technical choices

  • Take a pull in your local to get latest changes from the PR.
  • Open WP admin, Go to Settings > Media > Modern Image Formats > Image output format (Select "AVIF")
  • Upload WebP Image.
  • Check the frontend.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) no milestone PRs that do not have a defined milestone for release labels Dec 9, 2024
@mukeshpanchal27 mukeshpanchal27 self-assigned this Dec 9, 2024
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review December 9, 2024 05:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: adamsilverstein <[email protected]>
Co-authored-by: westonruter <[email protected]>
Co-authored-by: phanduynam <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

adamsilverstein
adamsilverstein reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work! I had one point about the use of $mime_type as a variable

@adamsilverstein
Copy link
Member

Nice work @mukeshpanchal27!

@mukeshpanchal27
Copy link
Member Author

@westonruter or @felixarntz Could one of you please review this so we can merge it? Thanks! 🙏

@westonruter westonruter added this to the webp-uploads n.e.x.t milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsilverstein adamsilverstein adamsilverstein approved these changes

@westonruter westonruter westonruter approved these changes

@felixarntz felixarntz Awaiting requested review from felixarntz felixarntz is a code owner

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels
no milestone PRs that do not have a defined milestone for release [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
webp-uploads n.e.x.t
Development

Successfully merging this pull request may close these issues.

Convert WebP to AVIF on upload
3 participants
@mukeshpanchal27 @adamsilverstein @westonruter