Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

Cover blocks does not look the same in the editor and on the front. #612

Closed
carolinan opened this issue Nov 16, 2018 · 4 comments · Fixed by #619
Closed

Cover blocks does not look the same in the editor and on the front. #612

carolinan opened this issue Nov 16, 2018 · 4 comments · Fixed by #619
Labels
bug Something isn't working

Comments

@carolinan
Copy link
Contributor

The size of cover blocks with a left align does not match the editor, the blocks on the front are much narrower.
-Do we want text to break this way?
-The right align looks OK.

Chrome version 70.0.3538.102 on pc, win 10:
Image background:
left-comparison

Video background:
video-comparison

Right aligned coverblock for comparison:
right-coverblock-front

When the cover blocks are centered, and the text has a right or left alignment, then there is no space around the text:
centered-blocks

Video background:
coverblock-text-right-front-video

@kjellr kjellr added the bug Something isn't working label Nov 16, 2018
@kjellr
Copy link
Collaborator

kjellr commented Nov 16, 2018

Hi @carolinan — can you confirm which version of the theme you're seeing this in? Many of these issues should've been fixed in #559, which is included in last night's 5.0 Beta5 update.

Thanks!

@carolinan
Copy link
Contributor Author

I am using 5.0-beta5-43907.

@kjellr
Copy link
Collaborator

kjellr commented Nov 16, 2018

Thanks, that's helpful. I'm able to reproduce most of this, and will open a PR shortly. 👍

@kjellr
Copy link
Collaborator

kjellr commented Nov 16, 2018

The center-alignment bugs mentioned are actually coming from Gutenberg. I've pushed a fix in via
WordPress/gutenberg#11990

The rest should be taken care of in #619. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
2 participants