-
Notifications
You must be signed in to change notification settings - Fork 127
Color palette and font presets are not shown as selected when the combined variation is active #634
Comments
@beafialho @juanfra |
Thanks Carolina, I'll be working to fix this. |
When I do I file comparison between the Sunrise theme style variation and typography preset 6,
|
And finally, when comparing Midnight with typography preset 7, the Midnight:
Preset 7:
|
Thanks for opening this issue, Carolina. That's right, they were perhaps missed when I did the reviews to each variation, so let's make sure they match with the following descriptions I left when I reviewed them: |
Description
I am lifting this out of #237
In this issue I am trying to summarize and find out why the matching color and typography presets are not showing as selected under
Appearance > Editor > Styles.
But I am hesitant to address this if the colors are going to be changed in any of the open pull requests, it will create more work and merge conflicts.
Dusk:
I made a file comparison and the color preset and the combined variation do match, so I can't tell why the Dusk color palette is not selected when the Dusk theme variation is selected.
Morning
I made a file comparison, and in the color preset, there is a difference in the button styles for section style four:
Theme variation:
Color preset:
If the button text color is added to the color preset, then the Morning color palette shows as selected when the Morning theme variation is selected.
Midnight
I did a file comparison and in the Midnight color preset file, the duotone is missing.
If the duotone is added to settings > colors, then the Midnight color palette shows as selected when the Midnight theme variation is selected.
The text was updated successfully, but these errors were encountered: