Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Implement the design of the quote block #184

Closed
carolinan opened this issue Sep 30, 2020 · 9 comments
Closed

Implement the design of the quote block #184

carolinan opened this issue Sep 30, 2020 · 9 comments
Assignees
Labels
[Component] Default blocks Issues related to adjusting default blocks

Comments

@carolinan
Copy link
Contributor

carolinan commented Sep 30, 2020

Current design:
quote_

In comparison to the pull quote these blocks only have one width and no color settings.
Related files:
https://github.com/WordPress/twentytwentyone/tree/trunk/assets/sass/05-blocks/quote

@carolinan carolinan added the [Component] Default blocks Issues related to adjusting default blocks label Sep 30, 2020
@carolinan
Copy link
Contributor Author

@luminuu luminuu self-assigned this Oct 3, 2020
@carolinan carolinan assigned JustinyAhin and unassigned luminuu Oct 7, 2020
@paaljoachim
Copy link

I am thinking an issue in the Gutenberg github repo would be fitting, so that we can add alignment and the additional color option located in the Pullquote block into the Quote block.

Using Twenty Twenty theme.
Chrome.
Localhost dev site.

Quote Block.
Quote-Block

Pullquote block.
Pullquote-Block

@carolinan
Copy link
Contributor Author

A quote block does not have anything to add the "main" color to. Pull quote has borders by default.

I don't think it is something the editor team should prioritize because of this theme.

@carolinan
Copy link
Contributor Author

The quote symbol itself should use the same symbol as used in the pull quote:

For refrence:

&::before {
	color: currentColor;
	content: "\201C";
	display: block;
	font-size: 3rem;
	font-weight: 500;
	line-height: 1;
}

https://github.com/WordPress/twentytwentyone/blob/trunk/assets/sass/05-blocks/pullquote/_style.scss#L14

@paaljoachim
Copy link

paaljoachim commented Oct 13, 2020

Btw
A PR is being worked on:
Quote: convert to nested blocks
WordPress/gutenberg#25892

Related to this issue: WordPress/gutenberg#15486

@JustinyAhin
Copy link
Member

Thanks Carolina.
Saw it this morning.

I'll send a pr from this branch this afternoon https://github.com/JustinyAhin/twentytwentyone/tree/fix/implement-block-quote-design

@carolinan
Copy link
Contributor Author

Btw
A PR is being worked on:
Quote: convert to nested blocks
WordPress/gutenberg#25892

Related to this issue: WordPress/gutenberg#15486

It is not milestoned for 9.2 and we can't add features after beta 1.

@paaljoachim
Copy link

Hey Poena. Check this link:
https://github.com/WordPress/gutenberg/projects/48#column-10737345

It is on the Project board WordPress 5.6 Must Haves.

@carolinan
Copy link
Contributor Author

carolinan commented Oct 15, 2020

Hey Poena. Check this link:
https://github.com/WordPress/gutenberg/projects/48#column-10737345

It is on the Project board WordPress 5.6 Must Haves.

It is not possible for us to work around issues that are not complete before beta 1, our time line is the same, not "after Gutenberg".

@carolinan carolinan reopened this Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Component] Default blocks Issues related to adjusting default blocks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants