Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Introduce WP_Block and WP_Block_List classes #351

Closed
wants to merge 7 commits into from
Closed

Editor: Introduce WP_Block and WP_Block_List classes #351

wants to merge 7 commits into from

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Jun 23, 2020

Trac ticket: https://core.trac.wordpress.org/ticket/49926

This PR ports the most up-to-date version of the WP_Block and WP_Block_List classes added to Gutenberg:

https://github.com/WordPress/gutenberg/blob/master/lib/class-wp-block.php
https://github.com/WordPress/gutenberg/blob/master/lib/class-wp-block-list.php

It also adds corresponding unit tests.

There is a follow-up backport necessary to wire this class when using new block context features as tracked in https://core.trac.wordpress.org/ticket/49927.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@gziolo gziolo changed the title Editor: Introduce WP_Block class Editor: Introduce WP_Block and WP_Block_List classes Jun 23, 2020
@TimothyBJacobs
Copy link
Member

I think this needs @since comments on all the classes, methods, and properties not just for the file.

@gziolo gziolo closed this Jun 25, 2020
@gziolo gziolo deleted the add/wp-block-class branch June 25, 2020 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants