Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay loading comment-reply script with async loading strategy #4876

Closed
wants to merge 2 commits into from

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Jul 20, 2023

Trac ticket: https://core.trac.wordpress.org/ticket/58870

Commit message:

Script Loader: Delay loading comment-reply script with async loading strategy.

Props westonruter, flixos90, joemcgill, sergiomdgomes.
See #12009.
Fixes #58870.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…into trac-58870

* 'trunk' of https://github.com/WordPress/wordpress-develop:
  Help/About: Fix the Get Involved tab on Network Admin.
  Build/Test Tools: Restore automatically retrying failed E2E tests once.
  Editor: Fix conditionals in Template Editing Mode.
  Coding Standards: Always declare visibility for class methods.
  Twenty Twenty-One: Enable Dark Mode in the block editor iframe.
  HTML API: Change `wp` infix in test classes to `Wp`.
  Editor: update npm packages with bug fixes for 6.3 RC2.
  Editor: load title on navigation fallback.
  Help/About: Updates to About page.
  Administration: Update dashboard welcome panel for 6.3.
  Help/About: Add illustrations to the Get Involved tab
  Editor: Fix abbreviations of "Example" in `block-template-utils.php`.
  Coding Standards: Remove trailing tabs in `wp-admin/about.php`.
  Editor: fix popover positioning.
  Coding Standards: Correct alignment in `wp-includes/media.php`.
  Media: Fix Image rotation button overflow in translations.
  Coding Standards: Always use parentheses for class instantiation.
  General: Commit changes after running `precommit:css`.
  Media: Fix height max value in image scaling.
  I18N: Add missing translator comment in `WP_Upgrader::generic_strings()`.
@westonruter westonruter requested a review from azaozz July 25, 2023 21:45
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, using async makes sense to me. If there is any plugin that depends on the script, it would still work given that core would then change this script back to blocking.

@westonruter
Copy link
Member Author

Committed to trunk in 73be680

@westonruter westonruter deleted the trac-58870 branch July 28, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants