Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo Feedback: Remove the SMS/App columns from the settings table #106

Closed
bacoords opened this issue Jul 28, 2022 · 1 comment · Fixed by #284
Closed

Demo Feedback: Remove the SMS/App columns from the settings table #106

bacoords opened this issue Jul 28, 2022 · 1 comment · Fixed by #284
Labels
Needs Design Feedback [Scope] Boundary - Settings Communication with WordPress' Settings API

Comments

@bacoords
Copy link
Collaborator

I would assume that neither of these will make it into the final product (though would be something that could be 'turned on' via additional plugin or something when we get to adding hooks). In any case they're probably not logical for 80% of WordPress websites out there.
@bacoords bacoords added Needs Design Feedback [Scope] Boundary - Settings Communication with WordPress' Settings API labels Jul 28, 2022
@johnhooks johnhooks mentioned this issue Apr 19, 2023
Merged
@johnhooks
Copy link
Collaborator

@bacoords we are removing these options in #284.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Design Feedback [Scope] Boundary - Settings Communication with WordPress' Settings API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove SMS and App from demo settings options johnhooks/wp-feature-notifications
2 participants
@bacoords @johnhooks