-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add template, pattern and styles for Enterprise page #157
Conversation
4ae3c5e
to
2b75bbf
Compare
source/wp-content/themes/wporg-main-2022/patterns/enterprise.php
Outdated
Show resolved
Hide resolved
source/wp-content/themes/wporg-main-2022/patterns/enterprise.php
Outdated
Show resolved
Hide resolved
source/wp-content/themes/wporg-main-2022/patterns/enterprise.php
Outdated
Show resolved
Hide resolved
source/wp-content/themes/wporg-main-2022/patterns/enterprise.php
Outdated
Show resolved
Hide resolved
source/wp-content/themes/wporg-main-2022/patterns/enterprise.php
Outdated
Show resolved
Hide resolved
f1e06cf
to
5ef2dad
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
b764aba
to
f8b4568
Compare
Updated screenshots below with constrained layout and 'Try WordPress' font size reduced to fit (99px, down from 120px), rather than using letter spacing. @javierarce @panchovm please let me know what you think.
|
a73c919
to
8f9b62b
Compare
This looks good. 👍 I do find that the "WordPress Enterprise" graphic gets blurry on my large desktop. |
- Remove custom header CSS - Bottom align Use Cases - Use external-link class
5b2771e
to
f70a6e8
Compare
35c5784
to
7c81380
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been trying to set up and run the PR in my local, but I couldn't. So instead of keep pining folks for help and delaying my comments, I will share feedback based on the screenshots shared. Sorry for jumping in late.
The page looks great across breakpoints, I just noticed the following in mobile:
- Images in Features section are slightly bigger compared to the mockup.
- Top and bottom paddings look tighter compared to the mockup.
- Section headings, below Try WordPress action, look smaller. The mockup's style is
Heading 5
.
The font-size reduction in Try WordPress works well.
@panchovm thanks for the feedback!
We have a rule in the parent theme for all the redesigned sites which reduces the size of H5 headings from 26px to 20px on mobile: https://github.com/WordPress/wporg-parent-2021/blob/trunk/source/wp-content/themes/wporg-parent-2021/theme.json#L334 Does this rule need to be adjusted? If it's not intended to be applied globally, we could specifically resize the other places it's applied, on the Download pages: 'Everything you need to set up your site just the way you want it.' 'Number of WordPress 6.1 downloads' I have reduced the size of the Features icons to match the design (now 58px high), and increased the padding on the header and features sections as they seemed the furthest off. Again these paddings are controlled globally and clamped on mobile, so to some degree we try to go with these settings that have been developed on other pages. |
77e2285
to
e5541b1
Compare
467f4fc
to
e5541b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks great. We should keep consistency across the site, so your approach is perfect.
Thanks for the work ✨
Closes #150
Adds a template and pattern for the Enterprise page. Some custom styles have had to be added, mostly for the logo grid which changes layout significantly on mobile.
Remaining tasks:
Props @bengreeley
Screenshots
How to test the changes in this Pull Request:
enterprise
(an existing page may need to be deprecated in your site)yarn workspace wporg-main-2022-theme build