-
-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitbake rules match all '*.conf' files. #1000
Comments
I'm happy to make a pull request with that change, but for an 8 character change that seems a bit over the top . . . |
Thank you for your issue! Seems like an appropriate step to take for now. Can I ask what language are you using in your project that uses the All PRs large and small are welcome and appreciated :) |
This is a puppet environment - it's got a whole bunch of files of various types, including templates for config files in at least ten different formats, and plain config files in another ten different formats. I don't know if a generic "config file" language config would be viable, there are probably some reasonable assumptions you could make ('#' or ';' for line comments would probably work for the majority of what you might call generic *.conf files), but they'd be necessarily broad . . . But it's pretty obvious to me that no specific language should lay claim to the .conf extension - that way lies madness. PR submitted, #1001 - I didn't see anything in the contributors doco about sign off or anything like that, if I missed something let me know and I'll fix it. |
Yeah, five minutes looking through I /think/ that would be something like:
Though that might be claiming more than it should, if the only option for deciding what language rule to match is the extension then that's probably the best it could do. I just submitted a PR with that, #1002. |
I'm not sure what the correct way to handle *.conf files is, but it seems unlikely that assigning them all to the Bitbake language is the appropriate choice.
This rule was added with commit da0841d from August 2022. I assume the fix would be something like:
The text was updated successfully, but these errors were encountered: