Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new base58 parser (Version: 2.1.0) #1211

Closed
godexsoft opened this issue Feb 26, 2024 · 2 comments
Closed

Use new base58 parser (Version: 2.1.0) #1211

godexsoft opened this issue Feb 26, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@godexsoft
Copy link
Collaborator

Summary

rippled introduced a new, faster parser for base58: XRPLF/rippled#4327

Motivation

15x faster than the previous implementation. It shows about 10% speedup for RPC commands in rippled and should be for Clio too.

Solution

Use the new parser.

Paths Not Taken

  • Write our own parser.
  • Use a library
  • Leave as is
@godexsoft godexsoft added the enhancement New feature or request label Feb 26, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Clio Feb 26, 2024
@cindyyan317
Copy link
Collaborator

Link with #88

@godexsoft godexsoft added this to the 2.3 milestone Jun 18, 2024
@godexsoft
Copy link
Collaborator Author

Looks like nothing to do in Clio in order to support this.
The fast algorithm is automatically used when compiled outside of MSVC (relies on __int128 found in both gcc and clang).
Clio already uses libxrpl's base58 functions and does not use other 3rd party library for this nor introduces a custom parser for base58.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Merged in Clio Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Merged
Development

No branches or pull requests

2 participants