Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor connection tags #1668

Open
kuznetsss opened this issue Sep 26, 2024 · 1 comment
Open

Refactor connection tags #1668

kuznetsss opened this issue Sep 26, 2024 · 1 comment
Labels
bug Something isn't working refactoring Code improvements without logical changes
Milestone

Comments

@kuznetsss
Copy link
Collaborator

Summary

Currently connection tags (file Taggable.hpp) are written in very OOP style with a lot of classes to follow OOP practices. It could be simplified. Also probably taggable could be a wrapper above log class doing logging with tag. Such design would guaranty that we didn't forget to put a tag somewhere.

@kuznetsss kuznetsss added the refactoring Code improvements without logical changes label Sep 26, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Clio Sep 26, 2024
@godexsoft godexsoft added this to the 2.4 milestone Oct 21, 2024
@kuznetsss kuznetsss modified the milestones: 2.4, 2.5 Oct 21, 2024
@kuznetsss
Copy link
Collaborator Author

kuznetsss commented Oct 30, 2024

Current tags implementation may have an undefined behaviour if parent tag lives less than a child one. I'm adding bug label here. And also removing milestone to reconsider the urgency of this issue.

@kuznetsss kuznetsss added the bug Something isn't working label Oct 30, 2024
@kuznetsss kuznetsss removed this from the 2.5 milestone Oct 30, 2024
@godexsoft godexsoft added this to the 2.4 milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactoring Code improvements without logical changes
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants