Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow server to report its current manifest #3099

Closed
nbougalis opened this issue Oct 7, 2019 · 1 comment
Closed

Allow server to report its current manifest #3099

nbougalis opened this issue Oct 7, 2019 · 1 comment
Labels
Good First Issue Great issue for a new contributor

Comments

@nbougalis
Copy link
Contributor

nbougalis commented Oct 7, 2019

We need rippled to improve its manifest support:

  1. A rippled instance configured as a validator should offer an admin-only RPC command that can report the master public key, the ephemeral public key, the manifest sequence number and, if present, the domain associated with the manifest that the server is using. The command can be validator_info. If the server is not configured as a validator, the command should report an error.
  2. Any rippled instance should offer an RPC command that, given a master or ephemeral public key, should report the master public key, the ephemeral public key, the manifest sequence number the domain associated with the given manifest (if present), and the manifest in base64-encoded format. The command can be manifest. If the server does not have the given manifest, the command should report an error.

Optionally, for (1) a --validator-info command line should parse the config file, load the validator_token if one is present, and report the master and ephemeral public keys, the manifest sequence number and, if present, the domain associated with the manifest. Additionally, the command should report the base64 encoded manifest. Once completed, the program would terminate (similar to, e.g. --version)

@nbougalis nbougalis added the Good First Issue Great issue for a new contributor label Oct 7, 2019
@nbougalis nbougalis changed the title Allow server to report its latest manifest Allow server to report its current manifest Oct 7, 2019
@intelliot
Copy link
Collaborator

  1. validator_info has been implemented
  2. manifest has been implemented*

*(manifest was implemented as an admin-only command, but I think it would be fine to make it public)

I'm not certain of the status of the command line feature idea, but if it is still needed, we should create a new issue for it. The title of this issue (Allow server to report its current manifest) is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Great issue for a new contributor
Projects
None yet
Development

No branches or pull requests

2 participants