Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md is missing #3312

Closed
denizdanaei opened this issue Mar 24, 2020 · 5 comments
Closed

CONTRIBUTING.md is missing #3312

denizdanaei opened this issue Mar 24, 2020 · 5 comments
Labels
Feature Request Used to indicate requests to add new features Good First Issue Great issue for a new contributor

Comments

@denizdanaei
Copy link

Summary

After a thorough search for a document that would guide a new contributor where to start in rippled repository, I concluded that there is none for this project, and I decided to suggest it as an issue.

There is already a CONTRIBUTING.md file for xrpl-dev-portal repository, though that is aimed for that specific repository.

Motivation

I am taking a course, which I am studying ripple in detail. One of my tasks for this course is to contribute to this project.
I first started by checking the label good first issue. However, I was lost after 10 min since I did not know where to start, what I need to know beforehand, which parts of the code I should first study to understand the basics of the underlying system, how to set up the environment for developing and contributing to the project, and so on.

Solution

Simple! 😊 Adding contribution.md just like other open-source projects! i.e., ATOM's contributing.md

@denizdanaei denizdanaei added the Feature Request Used to indicate requests to add new features label Mar 24, 2020
@denizdanaei denizdanaei changed the title CONTRIBUTING.md is missing for rippled CONTRIBUTING.md is missing Mar 24, 2020
@thejohnfreeman
Copy link
Collaborator

Great questions. I'll try to give a few answers. Maybe as others chip in, we can collate the answers into a CONTRIBUTING.md at the end.

For build, there are instructions buried in the repository for Linux, Mac, and Windows. They should be mostly up-to-date, but they are only ever tested by new contributors like yourself. If you run into trouble, please open more issues.

For an overview of the codebase, there's a good audit from another contributor, @movitto, of the code for version 1.1.0. Because it is actively developed, rippled is a moving target, so any audit of a specific version will fall out-of-date as it ages, but the core of rippled is pretty stable, so the audit is still mostly applicable for now. I'd like to see us contribute more such documentation into the codebase, near the code, and render it with Doxygen online. I'm hosting the latest version, for 1.5.0, from my fork's gh-pages branch. Poke around the Related Pages for some overviews (rendered from Markdown documents sprinkled through the codebase).

@carlhua
Copy link
Contributor

carlhua commented Mar 24, 2020

to add on what @thejohnfreeman has provided, consider this feature request itself a potential "contribution" to the project @denizdanaie ! We would love to have external contributors to help us make the project better. As you find your ways around the project, feel free to ask questions as we are here to help. In addition, consider making a contribution (PR) to this feature request as you see fit!

@carlhua carlhua added the Good First Issue Great issue for a new contributor label Apr 3, 2020
@sneh19337
Copy link

I would take the help of all the resources mentioned above and will send a PR of Contributing.md

@wojake
Copy link
Collaborator

wojake commented Oct 5, 2021

Ye, we really need a CONTRIBUTING.md, I was pretty confused when browsing the repo because the CONTRIBUTING.md was no where to be found.

@intelliot
Copy link
Collaborator

Completed by #4214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Used to indicate requests to add new features Good First Issue Great issue for a new contributor
Projects
None yet
Development

No branches or pull requests

6 participants