-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace dependencies on aged_containers #3337
Comments
Alternatively, we should consider whether submitting them for inclusion in Boost makes sense. I know that this would require extra effort on our part, unless someone else is willing to adopt them and push them through Boost review. |
If Mr. V wants to adopt them I'd be fine with that. But I doubt anyone on this team wants to adopt them thoroughly enough to get them through the Boost review process. I tried doing that once years ago with a small utility that I wrote (and was not accepted). The Boost review process can be brutal. |
@scottschurr do you still think this is worth doing? |
Yes, removing the The |
Case in point: #4486 |
|
Issue Description
The collection of aged_containers (see
src/ripple/beast/container
) are STL-like containers that track the relative age of their contents. The aged_containers are specific to rippled, which means that they are maintained locally. The fact that they are STL-like carries with it all of the associated complexity.The amount of complexity and maintenance risk that the aged_containers carries is not justified by the role they fill in the rippled code base. We should find
std::
(preferable) orboost::
replacements for all uses of the aged_containers in the rippled code base, even if that means incurring some performance penalties. Once all uses of the aged_containers have been replaced, then we should remove the aged_container source code.The text was updated successfully, but these errors were encountered: