Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test to tapPREFER_QUEUE flag #3496

Closed
carlhua opened this issue Jul 8, 2020 · 2 comments
Closed

Add unit test to tapPREFER_QUEUE flag #3496

carlhua opened this issue Jul 8, 2020 · 2 comments
Assignees
Labels
RIPD Export Exported from legacy JIRA issue tracking Tech Debt Non-urgent improvements

Comments

@carlhua
Copy link
Contributor

carlhua commented Jul 8, 2020

Here’s the commit that added the flag: ximinez@62127d7 There are no unit tests where this flag is being exercised, including the manual tests.

Considering the tapPREFER_QUEUE flag was added in response to a critical event, I believe we should be exercising the flag during testing. Someone will need to study the code in order to identify the conditions necessary to exercise the flag.

Exported from RIPD-1792

@carlhua carlhua added Tech Debt Non-urgent improvements RIPD Export Exported from legacy JIRA issue tracking labels Jul 8, 2020
@carlhua carlhua changed the title tapPREFER_QUEUE flag not exercised by any unit tests Add unit test to tapPREFER_QUEUE flag Jul 8, 2020
@intelliot
Copy link
Collaborator

@ximinez
Copy link
Collaborator

ximinez commented Aug 30, 2023

The flag was removed in ae9930b, which was released in 1.8.2.

@ximinez ximinez closed this as completed Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RIPD Export Exported from legacy JIRA issue tracking Tech Debt Non-urgent improvements
Projects
None yet
Development

No branches or pull requests

4 participants