Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cashing a check should automatically create a trustline #3790

Closed
nbougalis opened this issue Mar 10, 2021 · 6 comments
Closed

Cashing a check should automatically create a trustline #3790

nbougalis opened this issue Mar 10, 2021 · 6 comments
Labels
Amendment Feature Request Used to indicate requests to add new features

Comments

@nbougalis
Copy link
Contributor

It is currently possible to send a Check even if the recipient doesn't have a trustline for the asset being delivered. However, attempting to cash the check will fail in the absence of a trustline.

Certain use cases would benefit from the ability to automatically create the trustline during check cashing. This is not a problem since it can only happen in response to explicit action by the recipient (similarly to how one can place an offer to purchase an asset without having a trustline established, and the system creates the trustline automatically if and when the order is filled).

The created trust line should have the limit set to 0. Optionally, the "cash" transaction could have a field that allow the recipient to manually specify a different limit.

@nbougalis nbougalis added Feature Request Used to indicate requests to add new features Amendment labels Mar 10, 2021
@nbougalis
Copy link
Contributor Author

This is in connection with XRPLF/XRPL-Standards#30

@mDuo13
Copy link
Collaborator

mDuo13 commented Mar 10, 2021

Agreed, and cashing a Check should allow you to accept "over" your limit amount in the same way that an Offer can.

@RichardAH
Copy link
Collaborator

What's the status of this? Are you still planning to introduce it as an amendment?

@nbougalis
Copy link
Contributor Author

Yes. I did some of the prep work but the code to do this is a little more involved than I previously thought. If someone else wants to tackle it, that'd be cool, but if not, we'll probably get on in a few days.

@mDuo13
Copy link
Collaborator

mDuo13 commented Mar 24, 2021

In the meantime, another option for people who want to issue an NFT would be to offer it to the world via an OfferCreate (at some predetermined price, I suppose) and let whoever wants it claim the NFT with their own OfferCreate. Though, I suppose if you're following the "very small numbers as NFTs" proposal you'd want to make sure the rounding can't do something weird with partially-crossed offers. I don't actually know how the rounding might work if someone's offer partially crosses yours.

@tequdev
Copy link
Contributor

tequdev commented Feb 11, 2023

I think this Issue can be Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Amendment Feature Request Used to indicate requests to add new features
Projects
None yet
Development

No branches or pull requests

5 participants